[HIP] Builder for third-party libraries (Kokkos first) #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxsamliu
approved these changes
Mar 5, 2025
gkistanova
requested changes
Mar 8, 2025
Contributor
gkistanova
left a comment
gkistanova
left a comment
There was a problem hiding this comment.
Thanks for the patch, JP.
It looks fine with one small thing to address.
| 'tags' : ["amdgpu", "offload", "openmp"], | ||
| 'workernames' : ["ext_buildbot_hw_05-hip-docker"], | ||
| 'builddir': "hip-third-party-libs-test", | ||
| 'collapseRequests' : True, |
Contributor
There was a problem hiding this comment.
This would make the builder collapse all the build requests unconditionally. You do not want this, Just remove this argument and let the default machinery do the work.
This adds: - Builder for HIP-enabled Kokkos library build+test - Worker for that builder - Script for AnnotatedBuilder to build third-party libraries This increases HIP test coverage substantially in the upstream and helps to identify issues earlier. Initially, this will contain only Kokkos. The Ginkgo library is lined up and will be added next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
This increases HIP test coverage substantially in the upstream and helps to identify issues earlier.
Initially, this will contain only Kokkos.
The Ginkgo library is lined up and will be added next.