Skip to content

Enable OpenMP and Add new WoA 2stage worker #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omjavaid merged 1 commit into from
Jul 2, 2025
Merged

Enable OpenMP and Add new WoA 2stage worker #488

omjavaid merged 1 commit into from
Jul 2, 2025

Conversation

@omjavaid
Copy link
Contributor

@omjavaid omjavaid commented Jun 30, 2025

This patch introduces the following changes:

  1. A new AArch64 Windows worker linaro-armv8-windows-msvc-03 for clang-arm64-windows-msvc-2stage builder.

  2. The OpenMP is enabled for the clang-arm64-windows-msvc-2stage builder via -DLLVM_ENABLE_RUNTIMES=openmp CMake flag.

@omjavaid
Enable OpenMP and Add new WoA 2stage worker
2ccb417 
This patch introduces the following changes:

1. A new AArch64 Windows worker linaro-armv8-windows-msvc-03 for
   clang-arm64-windows-msvc-2stage builder.

3. The OpenMP is enabled for the clang-arm64-windows-msvc-2stage
   builder via -DLLVM_ENABLE_RUNTIMES=openmp CMake flag.
@omjavaid omjavaid requested a review from DavidSpickett June 30, 2025 16:48
DavidSpickett
DavidSpickett reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you state whether you intend this to run tests or just enable it so flang can use it?

If it's the former, I assume the tests have been stable? OpenMP likes parallelism so it's a risk.

@omjavaid
Copy link
Contributor Author

omjavaid commented Jul 1, 2025

Can you state whether you intend this to run tests or just enable it so flang can use it?

If it's the former, I assume the tests have been stable? OpenMP likes parallelism so it's a risk.

For now its just for adding openmp test coverage on the second stage. We will consider testsuite later.
OpenMP is enabled on both clang-arm64-windows-msvc and flang-arm64-windows-msvc. So its reasonable to believe that OpenMP tests will run fine on the 2 stage bot as well. Also we add an additional worker so its will ease out some of this builders load.

DavidSpickett
DavidSpickett approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omjavaid omjavaid merged commit 9b44a4c into llvm:main Jul 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidSpickett DavidSpickett DavidSpickett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omjavaid @DavidSpickett