[CI] Add support for windows to dispatch_job.py #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Aug 5, 2025
This patch adds in windows functionality to dispatch_job.py. Some minor refactoring was done around the start_build function so that the core functionality can be reused between Linux and Windows. Pull Request: llvm#540
boomanaiden154
requested review from
Keenuts,
cmtice,
dschuff,
gburgessiv and
lnihlen
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Aug 5, 2025
This patch adds in windows functionality to dispatch_job.py. Some minor refactoring was done around the start_build function so that the core functionality can be reused between Linux and Windows. Pull Request: llvm#540
cmtice
reviewed
Aug 6, 2025
cmtice
reviewed
Aug 6, 2025
cmtice
reviewed
Aug 6, 2025
cmtice
reviewed
Aug 6, 2025
|
|
||
|
|
||
| def start_build_linux(commit_sha: str, k8s_client) -> str: | ||
| pod_name = f"build-{commit_sha}" |
There was a problem hiding this comment.
Added. I kept them as one liners as these functions should be reasonably self documenting.
cmtice
reviewed
Aug 6, 2025
|
|
||
|
|
||
| def start_build_windows(commit_sha: str, k8s_client): | ||
| pod_name = f"build-{commit_sha}" |
There was a problem hiding this comment.
Same as above.
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Aug 6, 2025
This patch adds in windows functionality to dispatch_job.py. Some minor refactoring was done around the start_build function so that the core functionality can be reused between Linux and Windows. Pull Request: llvm#540
boomanaiden154
added a commit
to boomanaiden154/llvm-zorg
that referenced
this pull request
Aug 6, 2025
This patch adds in windows functionality to dispatch_job.py. Some minor refactoring was done around the start_build function so that the core functionality can be reused between Linux and Windows. Pull Request: llvm#540
cmtice
approved these changes
Aug 6, 2025
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.ci-add-support-for-windows-to-dispatch_jobpy
to
main
boomanaiden154
deleted the
users/boomanaiden154/ci-add-support-for-windows-to-dispatch_jobpy
branch
vvereschaka
pushed a commit
to vvereschaka/llvm-zorg
that referenced
this pull request
Sep 25, 2025
This patch adds in windows functionality to dispatch_job.py. Some minor refactoring was done around the start_build function so that the core functionality can be reused between Linux and Windows. Reviewers: cmtice, gburgessiv, lnihlen, dschuff, Keenuts Reviewed By: cmtice Pull Request: llvm#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds in windows functionality to dispatch_job.py. Some minor
refactoring was done around the start_build function so that the core
functionality can be reused between Linux and Windows.