Skip to content

Conversation

jayfoad
Copy link
Contributor

@jayfoad jayfoad commented Sep 2, 2025

check-llvm does not run tests for the llvm-lit utility, so run the check-lit target as well.

@jayfoad
Copy link
Contributor Author

jayfoad commented Sep 2, 2025

I don't usually work on zorg. I don't know if this is the right place to implement this, and I don't know how to test it. Reviews welcome! Thanks.

@jayfoad
Copy link
Contributor Author

jayfoad commented Sep 2, 2025

This came up in review of llvm/llvm-project#94621.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only runs on the premerge postcommit builders, but that should be fine. We'll want to add coverage for this on the premerge side, but I can put up a patch for that.

@jayfoad jayfoad merged commit e49a696 into main Sep 17, 2025
3 checks passed
@jayfoad jayfoad deleted the jayfoad-patch-1 branch September 17, 2025 06:38
vvereschaka pushed a commit to vvereschaka/llvm-zorg that referenced this pull request Sep 25, 2025
`check-llvm` does not run tests for the `llvm-lit` utility, so run the
`check-lit` target as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants