Skip to content

Conversation

DavidSpickett
Copy link
Contributor

@DavidSpickett DavidSpickett commented Oct 8, 2025

Instead of "setup.py develop". Fixes llvm/llvm-lnt#76.

The new process is tested in CI so we can catch problems before they get to the buildbots.

https://llvm.org/docs/lnt/quickstart.html#installation

The bots only use the client so I've used that specific requirement file as suggested.

The requirement file has an entry ".". This means "install the package defined in the current directory". "current" means the current working directory, not the directory the requirement file is in.

This is handled by running the install command from within the LNT checkout. LNT will still be installed in the sandbox as expected.

Instead of "setup.py develop". Fixes llvm/llvm-lnt#76.

The new process is tested in CI so we can catch problems before
they get to the buildbots.

The bots only use the client so I've used that specific requirement
file as suggested.

The requirement file has an entry ".". This means "install the package
defined in the current directory". "current" means the current working directory,
not the directory the requirement file is in.

This is handled by running the install command from within
the LNT checkout. LNT will still be installed in the sandbox as
expected.
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for fixing!

@ldionne
Copy link
Member

ldionne commented Oct 9, 2025

Note that while this might not be the final way we want to install lnt, it's better than running setup.py. As long as we maintain a requirements.txt that works, we'll be able to iterate on stuff in lnt without breaking these bots.

@ldionne
Copy link
Member

ldionne commented Oct 10, 2025

Merging to try to make progress on the LNT side.

@ldionne ldionne merged commit bfc7dcc into llvm:main Oct 10, 2025
3 checks passed
@DavidSpickett
Copy link
Contributor Author

Merging to try to make progress on the LNT side.

Be aware that this does not propogate to the bots right away. The master needs to be restarted before that happens.

I'll ask Galina for a restart. You can check the steps of one of the bots like https://lab.llvm.org/buildbot/#/builders/17 to see if the change has been applied yet.

@DavidSpickett DavidSpickett deleted the lnt-install branch October 10, 2025 10:59
@DavidSpickett
Copy link
Contributor Author

Actually I'll ask once I confirm whether setuptools is still needed.

@DavidSpickett
Copy link
Contributor Author

We need setuptools as long as we are using setup.py I think. Newer versions of virtualenv do not install it by default.

I've requested a restart.

@DavidSpickett
Copy link
Contributor Author

Bots have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lab.llvm.org build bots should use the now-documented pip requirements installation procedure

2 participants