[Torch] [TMTensor] Added mask and is_causal support for torch.aten.scaled_dot_product_attention #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caled_dot_product
rohan-tan-bhowmik
requested review from
raikonenfnu,
rsuderman and
vivekkhandelwal1
raikonenfnu
reviewed
Sep 6, 2024
rsuderman
requested changes
Sep 9, 2024
|
You need to still add the passing sdpa ops to the stable hlo tests |
rsuderman
requested changes
Sep 9, 2024
rsuderman
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled mask and is_causal parameters for torch.aten.scaled_dot_product attention + relevant comments + tests.
The tests added highlight the new capabilities introduced in this PR, including:
Attention with F16 mask
Attention with Boolean mask
Causal attention with same Q K V shapes
Causal attention without Q K V shapes
Made sure that one cannot input both mask and is_causal.