Skip to content

Conversation

lingzhiz1998
Copy link
Contributor

As discussed in #3652, we should replace maxpool3dwithindices with maxpool3d if indices have no user.

@lingzhiz1998 lingzhiz1998 force-pushed the lingzhi/canonicalization_for_maxpool3dwithindices branch from 2358fe8 to f2b5a33 Compare September 12, 2024 06:43
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lingzhiz1998
Copy link
Contributor Author

lingzhiz1998 commented Oct 18, 2024

@vivekkhandelwal1 Can you help to merge this PR? Thanks!

@vivekkhandelwal1 vivekkhandelwal1 merged commit 2f9a68c into llvm:main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants