[TorchToLinalg] Implement lowering of torch.aten.rrelu_with_noise and torch.aten.rrelu_with_noise_backward ops (fix) #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekkhandelwal1
requested changes
Oct 23, 2024
Collaborator
vivekkhandelwal1
left a comment
vivekkhandelwal1
left a comment
There was a problem hiding this comment.
Just a small change, and the rest looks good.
Collaborator
|
Hey @vivekkhandelwal1 this seems to be the commit that caused the CI to break on nightly. |
Contributor
Author
|
It seems that some tests started failing on later nightly builds, after I committed last changes. So I made this PR #3835 that addresses those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. @vivekkhandelwal1 This PR finalizes and resolves issues from #3645. Updated
xfail_setand cherry-picked previous implementation.