Skip to content

Conversation

@giacs-epic
Copy link
Contributor

@giacs-epic giacs-epic commented Oct 3, 2024

The asserts make the compiler crash (with a misleading error) also when vertical or horizontal dimensions are unknown (which is a valid state at this stage).
Add dynamic asserts when dimensions are not known.

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Does the conversion even work if the input shape is dynamic? Can we add a dynamic test (either a lit test or preferably an e2e test) to make sure that path actually works?

@giacs-epic
Copy link
Contributor Author

@zjgarvey I just added a dynamic test, it seems to work fine! I also took the chance to add dynamic asserts.

@giacs-epic
Copy link
Contributor Author

@zjgarvey I just added a dynamic test, it seems to work fine! I also took the chance to add dynamic asserts.

I struggle to understand the CI error. It seems like when exporting to onnx it interprets the input sizes as [1, 1, 1] instead of [1, -1, -1]. A PyTorch bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants