Skip to content

onnx.LSTM - bidirectional, layout attr #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

onnx.LSTM - bidirectional, layout attr #3771

merged 2 commits into from
Oct 8, 2024

Conversation

@PhaneeshB
Copy link
Collaborator

@PhaneeshB PhaneeshB commented Oct 7, 2024 •
edited
Loading

  • Support Bidirectional LSTM (utilising the forward LSTM layer with flipped Inputs and Outputs)
  • Support layout 1
  • Support default cases for attr clip and input_forget
  • Support returning partial outputs (1-3)
  • fixes for alt_e2e_tests lstm tests (1,2,3)

@PhaneeshB PhaneeshB mentioned this pull request Oct 7, 2024
Closed
renxida
renxida approved these changes Oct 7, 2024
View reviewed changes
@PhaneeshB PhaneeshB marked this pull request as ready for review October 8, 2024 18:10
@PhaneeshB PhaneeshB changed the title [WIP] onnx.LSTM - support bidirectional and layout attr onnx.LSTM - bidirectional, layout attr Oct 8, 2024
@renxida renxida merged commit 7830c00 into llvm:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renxida renxida renxida approved these changes

+1 more reviewer

@vinayakdsci vinayakdsci vinayakdsci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PhaneeshB @renxida @vinayakdsci