[Torch] Fold aten.to.dtype on splat constants.
#4306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure who can review, maybe you would know @vivekkhandelwal1 @zjgarvey ? |
mdazz
force-pushed
the
mdazz/add-todtype-folder
branch
from
3bf4e4b to
1d7b55b
Compare
sahas3
requested changes
Sep 11, 2025
mdazz
force-pushed
the
mdazz/add-todtype-folder
branch
2 times, most recently
from
9b8168c to
42edabd
Compare
This commit teaches `AtenToDtypeOp::fold` to constant-fold dtype conversions when the operand is a splat `DenseElementsAttr`. Folding is done according to torch's rounding behavior, i.e. * Bool: 0 and -0.0 → false; nonzero/NaN/±Inf → true. * Float → Int: round toward zero. * Int → Float: sign-aware, rmNearestTiesToEven. * Float ↔ Float: use builtin `mlir::FloatType::getFloatSemantics()`. * Int ↔ Int: use `zextOrTrunc` / `sextOrTrunc` based on source signedness. Folding is only performed when `non_blocking == false`, `copy == false`, and `memory_format` is None.
mdazz
force-pushed
the
mdazz/add-todtype-folder
branch
from
42edabd to
3abbd48
Compare
zjgarvey
approved these changes
Sep 25, 2025
sahas3
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Sorry this one slipped through the cracks. LGTM.
One suggestion for future is to not amend the git commit for changes that has been reviewed already when addressing feedback, so that it's easy for reviewers to only review the changes since the last feedback was provided. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit teaches
AtenToDtypeOp::foldto constant-fold dtype conversions when the operand is a splatDenseElementsAttr.Folding is done according to torch's rounding behavior, i.e.
mlir::FloatType::getFloatSemantics().zextOrTrunc/sextOrTruncbased on source signedness.Folding is only performed when
non_blocking == false,copy == false, andmemory_formatis None.