-
Notifications
You must be signed in to change notification settings - Fork 606
[WIP] Remove jit ir importer from the ci testing #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zjgarvey
wants to merge
15
commits into
main
Choose a base branch
from
users/zjgarvey/enable_e2e_test_no_jit_importer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zjgarvey <[email protected]>
…ke lists. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
… Make config loading localized to prevent errors. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
…ly set dynamo=False for now. Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
f584469
to
236c07d
Compare
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Signed-off-by: zjgarvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve issue #4343 by allowing e2e testing to run without building the
jit_ir_importer
, which does not have active maintainers, and is broken with the most recent pytorch release.Important considerations:
torch_mlir_e2e_test
is now included in the built python packages whetherjit_ir_importer
is enabled or not.jit_ir_importer
and pytorch extensions are now disabled in the ci build. Consequently, this involves removing all tests fromprojects/pt1
from the CI checks.jit_ir_importer
.TODO:
1. Update docs.2. Remove jit ir importer dependency from source generation scripts.
3. Check other scripts for build/release with respect to this change.