Add GitHub Actions CI workflow for unit tests#379
Merged
Conversation
Adds tests/unit-tests/test_ptask_free.c to verify all code paths of the psync_task_free fix from #377: single-owner free, last-ref destroy, non-last-ref decrement, READY task signaling, and lock-before-refcnt ordering. All 5 tests pass. Also adds compiled binary to .gitignore. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Triggers on push/PR to automated-testing branch. Installs cmake and build-essential, builds all test targets via cmake, and runs ctest --output-on-failure. Fails workflow on any test failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds tests and check targets to Makefile — no cmake required. Each test binary is built with the correct flags (pthread, -lrt, --wrap linker flags for prun/ptools_errptr). CI workflow installs only build-essential, runs make tests then make check; exits non-zero on any failure. All 8 test suites pass locally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
detect_fuse.sh runs at Makefile parse time; without fuse headers the $(error) fires before any target runs. Adding libfuse3-dev unblocks make tests (test binaries themselves don't link fuse). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Update CI workflow to run unit tests and build verification - Add Makefile targets for test compilation and execution - Implement unit tests for pdbg_path, prun, and read_response - Add test stubs for pCloud API mocking - Add test binaries for pfs_lock_ordering and signal_safety verification
Install libfuse-dev and libssl-dev required for build
Include unit test execution in C/C++ workflow
Complete stub implementations for all required pCloud API functions
Correct function signatures for pCloud API stubs
Correct all psql function signatures to match headers
Update stub functions and build configuration
Update Makefile to use actual implementation files for utilities
- Makefile: Add test rules with real dependencies - tests/stubs/test_stubs.c: Minimal stubs for external APIs - tests/stubs/test_stubs_cpp.c: Stubs for C++ test - pclsync/putil.c: Add null check in putil_strdup - pclsync/pdbg.c: Add recursion guard in pdbg_printf
Consolidate CI configuration into c-cpp.yml
- Remove test_pfs_lock_ordering and test_signal_safety binaries - Add tests/test_* to .gitignore to prevent future commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymltargeting theautomated-testingbranchcmake+build-essential(all test deps are glibc — pthread/rt, no external libs)cmake -B build && cmake --build buildctest --test-dir build --output-on-failure; workflow fails on any test failureTest plan
automated-testingtriggers workflow🤖 Generated with Claude Code