Rework Safenet serve content #7
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses various review comments received by email around the
SafeNetServeContentclass, for the purposes of the Keepsafe EU projects.An overview of the changes:
SafeNetServeContentwithEntitlementCheckServeContent, i.e. a subclass ofServeContentthat checks whether the user is entitled to see the content, and a generalEntitlementRegistryClientresponsible for checking thatorg.lockss.platform.project = safenetconfiguration is not used any more, and insteadorg.lockss.entitlement.keepsafe.enabled = truewould be used. Nobody except us would have been using that config parameterorg.lockss.safenetare now underorg.lockss.entitlementEntitlementRegistryClientthread-safe (raised in Create EntitlementRegistryClient for communicating with SafeNet ER #2)EntitlementRegistryClient(also from Create EntitlementRegistryClient for communicating with SafeNet ER #2)I can, if you wish, break this up further, and similarly could squash it into one commit, but I thought this was easier at the moment given the informal reviews we've done so far.