#23 Update dependencies and add static lifetime to SegmentedBuf...#24
Open
peter-lyons-kehl wants to merge 1 commit intologdna:mainfrom
Open
#23 Update dependencies and add static lifetime to SegmentedBuf...#24peter-lyons-kehl wants to merge 1 commit intologdna:mainfrom
peter-lyons-kehl wants to merge 1 commit intologdna:mainfrom
Conversation
c-nixon
suggested changes
May 27, 2022
Contributor
c-nixon
left a comment
c-nixon
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I'd rather not restrict T: 'static if we can avoid it. I have another suggestion for it
| // TODO: expose size when const generics become available | ||
| #[derive(PartialEq)] | ||
| pub struct SegmentedBuf<T> { | ||
| pub struct SegmentedBuf<T: 'static> { |
Contributor
There was a problem hiding this comment.
Hmm, I had a look at the countme code and it looks like we can avoid this by explicitly setting
_c: countme::Count<SegmentedBuf<T>>rather than using Self
Contributor
Author
There was a problem hiding this comment.
Unfortunately, I get the same error with _c: countme::Count<SegmentedBuf<T>>:
(That was after reverting the rest of source code to current main except for Cargo.toml. Same error with either stable Rust 1.61.0 or v1.63.0-nightly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #23