[HWORKS-1535] Infer model schema from feature view#241
Open
o-alex wants to merge 1 commit intologicalclocks:mainfrom
Open
[HWORKS-1535] Infer model schema from feature view#241o-alex wants to merge 1 commit intologicalclocks:mainfrom
o-alex wants to merge 1 commit intologicalclocks:mainfrom
Conversation
javierdlrm
requested changes
Aug 20, 2024
Comment on lines
+114
to
+118
| warnings.warn( | ||
| "Model schema can only be inferred if both a feature view and training dataset version are known", | ||
| util.ProvenanceWarning, | ||
| stacklevel=1, | ||
| ) |
Collaborator
There was a problem hiding this comment.
I wonder if this warning is useful for users. Do you think the following is clearer?
Model schema could not be inferred without feature view and training dataset version.
The method executes in any case. We just inform whether the model schema could not be inferred given the parameters.
Comment on lines
+151
to
+161
| if self._model_schema is None: | ||
| if ( | ||
| self._feature_view is not None | ||
| and self._training_dataset_version is not None | ||
| ): | ||
| features, labels = self._feature_view.get_training_data( | ||
| training_dataset_version=self._training_dataset_version | ||
| ) | ||
| self._model_schema = ModelSchema( | ||
| input_schema=features, output_schema=labels | ||
| ) |
Collaborator
There was a problem hiding this comment.
I think that having this in the constructor is enough, no need to retry it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.