Revert "random32: add prandom_u32_max and convert open coded users" #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a6cdc1c. Linux 3.10 does not have this function, because nothing in Linux 3.10 uses it. It was never backported in any of the kernel.org stable trees to 3.10. Its current inclusion in this pine64 kernel here adds nothing. The reason this is a problem is because wireguard's compat layer assumes that 3.10 kernels won't have this function, so having it here actually causes problems. Sure, we could work around this in wireguard, but it doesn't seem prudent to play the game of accounting for every possible frankenkernel out there. Instead this commit simply reverts the faulty backport. Signed-off-by: Jason A. Donenfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the deal is with all the various branches you have, but I'd appreciate it if in addition to merging this in whatever random branch I've selected for this PR, you could also cherry-pick it into all the other branches folks are using.
This reverts commit a6cdc1c.
Linux 3.10 does not have this function, because nothing in Linux 3.10
uses it. It was never backported in any of the kernel.org stable trees
to 3.10. Its current inclusion in this pine64 kernel here adds nothing.
The reason this is a problem is because wireguard's compat layer assumes
that 3.10 kernels won't have this function, so having it here actually
causes problems. Sure, we could work around this in wireguard, but it
doesn't seem prudent to play the game of accounting for every possible
frankenkernel out there.
Instead this commit simply reverts the faulty backport.
Signed-off-by: Jason A. Donenfeld [email protected]