Unity integration test revamp - Target stage #261
Conversation
There was a problem hiding this comment.
In general very pleased. Left some comments of things that we should adress but I'm gonna approve still so we can merge and have these on dev.
That said, we need to update the README.md file with instructions on how to test (add the testables: [ com.lootlocker.lootlockersdk ] thing and all that).
Tests/LootLockerTestUtils/LootLockerTestConfigurationException.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I went through the commits one by one because the PR was so large so sorry if some comments are outdated already (for example i in one commit comment to remove debug logs that you then remove in the next commit).
You're getting there, a lot of this is great work 💪
For next time though, you should have merged the PR (it was complete and approved when I left) and then split up your changes in different PRs. This was a pain to review.
|
Also, your tests are failing. They seem to be locking up somewhere and eventually timing out. Please fix |
AlmightyMikkel
force-pushed
the
ci/revamp
branch
from
e3f103f to
1f52082
Compare
There was a problem hiding this comment.
Added some more comments, generally on setup and configuration files. Didn't review the actual tests much further since I realized there are still like 30 unresolved (or resolved in GH but actually unresolved) comments in the PR. Will review later when it's more complete.
Tests/LootLockerTestUtils/LootLockerTestConfigurationException.cs
Outdated
Show resolved
Hide resolved
| }, true); | ||
| } | ||
|
|
||
| public static void CreateAsset(int contextID, Action<LootLockerTestAssetResponse /*asset*/> onComplete) |
There was a problem hiding this comment.
Why is the create asset method on the leaderboard class?
There was a problem hiding this comment.
Still questionable to me, but can't be bothered at the moment
Tests/LootLockerTestUtils/LootLockerTestConfigurationLeaderboard.cs
Outdated
Show resolved
Hide resolved
Tests/LootLockerTestUtils/LootLockerTestConfigurationLeaderboard.cs
Outdated
Show resolved
Hide resolved
kirre-bylund
force-pushed
the
ci/revamp
branch
from
c3d6ec8 to
97374f6
Compare
kirre-bylund
force-pushed
the
ci/revamp
branch
2 times, most recently
from
0fac3b4 to
349f5d2
Compare
This is a squashed commit of a long living branch. This commit consists of: 1. Initial workflow that targets stage 2. Added CI specific utils to store created users and games 3. Testing on Guest login 4. Testing on White Label Login 5. Testing on Leaderboard details and rewards 6. Testing on submitting scores to Leaderboards 7. Testing on Leaderboard listing, types, and metadata 8. Testing on Player Info 9. Testing on Pinging LootLocker's server 10. Testing on Player Storage, private, public and update 11. Removed ratelimiting while targeting stage 12. Added retry functionality for CI hitting ratelimiter
kirre-bylund
force-pushed
the
ci/revamp
branch
from
349f5d2 to
bd50f0f
Compare
2 participants
No description provided.