Skip to content

Conversation

@lquixada
Copy link
Owner

@lquixada lquixada commented Dec 11, 2024

@rollup/plugin-terser has a dependency called smob, whose lastest release (v1.5.0 at the time of this PR) breaks compatibility with Node 16.5-. cross-fetch@4.* minimum support for Node is 14. More on the issue here.

This PR replaces @roll-up/plugin-terser with rollup-plugin-esbuild for minification.

@lquixada lquixada marked this pull request as ready for review December 11, 2024 13:03
@lquixada lquixada self-assigned this Dec 11, 2024
@lquixada lquixada changed the title chore: switched minifier from @roll-up/plugin-terser to rollup-plugin-esbuild chore: switched minifier from @rollup/plugin-terser to rollup-plugin-esbuild Dec 11, 2024
@lquixada lquixada merged commit 67e778f into v4.x Dec 11, 2024
61 checks passed
@lquixada lquixada deleted the rollup-esbuild branch December 11, 2024 13:11
lquixada added a commit that referenced this pull request Dec 21, 2024
…esbuild (#195)

* fix: github actions was checking out the wrong ref

* chore: switched minifier from @roll-up/plugin-terser to rollup-plugin-esbuild-minify

* chore: chore: switched minifier from @roll-up/plugin-terser to rollup-plugin-esbuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants