Fix potential memory access issues #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* std::string_view::data() does not necessarily have a NUL
terminated string. So either convert to std::string() first
or have function parameters use a const char* to begin with
if that is what the caller provides.
* subtle: the absl cleanup got a _copy_ of the initial allocated
buffer pointer, but getline() will modify possibly that value as it
might reallocate. So call the cleanup with a reference.
Not an access issue, just simplification:
* in getting the env var, no need to convert to string_view first,
then back to string just to have a nul-terminated string.
We call that function with a const char* anyway.
Collaborator
Author
|
Thanks to |
lromor
reviewed
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an access issue, just simplification: