Add implementation signature of parse function to fix typings#32
Open
vkrol wants to merge 1 commit intolukeed:mainfrom
Open
Add implementation signature of parse function to fix typings#32vkrol wants to merge 1 commit intolukeed:mainfrom
vkrol wants to merge 1 commit intolukeed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without implementation signature we get an error when passing
string | RegExpto theparsefunction:https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXwAdYBnEAChh2QxAC55iMYtUBzAGnghx1IH56AIx4QQUVAEp6AbwBQASADWIAJ7F6jZmwDaAXQDcCohhoxU9AEohWAUQAeBQwF9Zs0JFgIU6bHkIlySmo6eCtbByl4OSVVdSQoCFJDeWNTc1Dre0dZF1d3aDh4MDxGeCCaDSYWVngAHwzw7NkiGFIKKhoJQyA
To fix this, I add the implementation signature to the
parsefunction: https://www.typescriptlang.org/play/?ssl=17&ssc=14&pln=15&pc=1#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXwAdYBnEAChh2QxAC55iMYtUBzAGnghx1IH56AIx4QQUVAEp6AbwBQASADWIAJ7F6jZmwDaAXQDcCohhoxU9AEohWAUQAeBQwF9ZoSLAQp02PIRLlKajp4K1sHKXg5JVV1JCgIUkN5Y1NzEOt7R1kXN2g4JDRMXHwiGFIKKhoNJhZWeAAfdLCCTm5eEAF4YRxRcQio5TVqrVY9BriEkCSUkDNLDIdnWWXcj3gwPEZ4QKqGGrZx0MzDWVLynZAJfSA