Skip to content

Improve wikilink parsing and checking #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Improve wikilink parsing and checking #1799

wants to merge 11 commits into from

Conversation

JayJayArr
Copy link
Contributor

@JayJayArr JayJayArr commented Aug 14, 2025 •
edited
Loading

  • Extract the correct filename from a Wikilink by removing potholes and fragments
  • Create a new Checker for wikilinks, make it clear to the users that a base-url is required
    • Check Obsidian style wikilinks without headers
    • strip fragments & potholes from wikilinks
    • traverse the wiki-directory and check if any of the Filenames exist with any of the specified --fallback-extensions

@JayJayArr JayJayArr changed the title Improve wikilinks, change to opt-in Improve wikilink parsing and checking Aug 18, 2025
@tooomm tooomm mentioned this pull request Aug 19, 2025
Closed
@JayJayArr JayJayArr mentioned this pull request Aug 19, 2025
Closed
@JayJayArr JayJayArr force-pushed the 1788-spaced-wikilinks branch from e9983af to f6f7814 Compare August 21, 2025 06:03
@JayJayArr
Copy link
Contributor Author

@jrfnl I am having trouble understanding the MediaWiki links with () and :.
Are there really markdown files named Help:Links or where do they point to?
Is [[Extension:DynamicPageList (Wikimedia)]] different to [[Extension:DynamicPageList]]

Could you please clarify this?

@JayJayArr JayJayArr force-pushed the 1788-spaced-wikilinks branch 3 times, most recently from ec15bc2 to 3a919db Compare September 30, 2025 10:24
@JayJayArr JayJayArr marked this pull request as ready for review September 30, 2025 12:28
@mre
Copy link
Member

mre commented Sep 30, 2025

Guess you can rebase on top of master now to fix CI.

mre
mre reviewed Sep 30, 2025
View reviewed changes
Copy link
Member

@mre mre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I've added a bunch of comments, but don't worry.
Most of them are about very minor paper cuts. Most of it can be fixed pretty easily by clicking on the "accept suggestion" button, I hope. 😉

@JayJayArr JayJayArr force-pushed the 1788-spaced-wikilinks branch 2 times, most recently from b251e14 to f6303a9 Compare October 3, 2025 17:10
JayJayArr and others added 10 commits October 13, 2025 14:24
@JayJayArr JayJayArr force-pushed the 1788-spaced-wikilinks branch 2 times, most recently from 3dce191 to c6c566f Compare October 13, 2025 12:42
@JayJayArr
feat: WikilinkChecker as optional
589e1f3 
include span in tests

fix: allow too many lines
@JayJayArr JayJayArr force-pushed the 1788-spaced-wikilinks branch from c6c566f to 589e1f3 Compare October 13, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mre mre mre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JayJayArr @mre