Add support for rswift.json config to BuildToolPlugin#896
Closed
TheNightmanCodeth wants to merge 1 commit intomac-cain13:mainfrom
Closed
Add support for rswift.json config to BuildToolPlugin#896TheNightmanCodeth wants to merge 1 commit intomac-cain13:mainfrom
rswift.json config to BuildToolPlugin#896TheNightmanCodeth wants to merge 1 commit intomac-cain13:mainfrom
Conversation
|
This config file is used only by RswiftGenerateInternalResources plugin. There are also RswiftGenerateResourcesCommand and RswiftGeneratePublicResources plugins. |
Author
|
Yeah good call this was a quick solution for a narrow use-case. There's another MR #899 raised just after this that, at a quick glance, appears to fill in those gaps. I'm going to go ahead and close this since I'm no longer using R.swift and don't plan on coming back to finish this out. If someone else would like to take what I've done and finish it in another MR that's fine with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there was no way to set custom arguments to the generation command when using SPM or Xcode BuildToolPlugin
This just allows for configuration via a
rswift.jsonfile placed at the project root (or elsewhere if it is added manually to the Xcode project)The config json would look like:
{ "generators": ["image", "string"], "rswiftignorePath": "/Users/TheNightmanCodeth/project/other/.rswiftignore", "additionalArguments": ["--somethingelse", "value"] }or any variation (ie. only additionalArguments, only generators and rswiftignorePath, etc.)
Addresses #860 (among others)