Open
Conversation
Member
|
wont the other command we run get hit by this though? |
Author
|
The release notes hint at that, but currently in the man page for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the 12.3 profiles man page:
umad currently relies on this command and will detect DEP status as false if the command returns an error. If the command is tried again within 23 hours it will result in an error.
This fix relies on detecting the dot files that this command alters located in
/private/var/db/ConfigurationProfiles/SettingsFrom our testing a machine that requires manual enrollment will always have a
.cloudConfigRecordNotFoundfile. This can be because the machine is not in DEP or because the MDM is not assigned, which does get removed when the command completes and the machine does have a valid MDM assigned.VMs with invalid serial numbers seem to result in returning a different error as shown:
With this detection, there is potentially a small gap during the first 23 hours after the change where the
.cloudConfigRecordFoundfile will contain invalid information. However, umad does not take this data into consideration.This should satisfy #44