Fix and include sls-muse build#15
Open
schlusslicht wants to merge 2 commits intomad-lab-fau:masterfrom
Open
Conversation
The deleted .so files were duplicates of the armeabi-v7 flavour. Further, on an aarch64 device, the arm64-v8a.so crashed the app.
schlusslicht
force-pushed
the
fix/sls-muse-build
branch
from
a32d75a to
85406ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
This pull request fixes a minor bug in the sls-muse module and appends the
:sls-musebuild target tosettings.gradle, so one can include theSensorLib:sls-musemodule via Jitpack (look forsensorlib:sls-musein the Jitpack build log).It further deduplicates the
libmuse_android.soJNI libraries, as all flavours are identical and deploying an app containing thearm64-v8a.soflavour crashed the app on an aarch64 device, while it runs fine with only thearmeabi-v7a.soin place.What this pull request contains
Issues/drawbacks
Longer build times (?)