Skip to content

Fix continuation misuse in case of timeout #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dioneea-sabs wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix continuation misuse in case of timeout #381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09f25a9
Fix continuation misues in case of timeout
dioneea-sabs Jan 27, 2024
ea0ae6c
Merge branch 'malcommac:master' into bugfix/continuation
dioneea-sabs Oct 16, 2024
02ac01e
Update SingleUpdateLocation.swift
dioneea-sabs Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/SwiftLocation/Async Tasks/SingleUpdateLocation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ extension Tasks {
}

DispatchQueue.main.asyncAfter(deadline: .now() + timeout) { [weak self] in
self?.continuation?.resume(throwing: LocationErrors.timeout)
guard let self else { return }
self.continuation?.resume(throwing: LocationErrors.timeout)
self.continuation = nil
self.cancellable?.cancel(task: self)
}
}
}
Expand Down