Skip to content

by slashrsm: Add support for comment-wrapped esi tags. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slashrsm wants to merge 4 commits into
base: master
Choose a base branch
from
Open

by slashrsm: Add support for comment-wrapped esi tags. #1

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c34202a
by slashrsm: Add support for comment-wrapped esi tags.
slashrsm Oct 30, 2013
c6ba83d
by slashrsm: Fix regular expression - make it actually an regexp.
slashrsm Oct 30, 2013
0ce18e2
by slashrsm: Remove ESI comment after being converted to standard ESI…
slashrsm Oct 31, 2013
99b2547
by slashrsm: Fix error with comment-wrapped esi tags when there are o…
slashrsm Nov 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions jquery.esi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@
// Retrieve the base DOM element, in order to access the DOM method
// getElementsByTagName.
base_element = $(this).get(0);
// Discover comment-wrapped <esi:include> tags and move them out of the comment.
jQuery("*:not(iframe)").contents()
.filter(function(){ return this.nodeType == 8 && this.nodeValue.match(/^esi/);})
Copy link
Owner

@manarth manarth Oct 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the value 8 has a corresponding named constant COMMENT_NODE ( see http://www.w3schools.com/jsref/prop_node_nodetype.asp ). Could you check if the constant also works correctly in your use-case?

Copy link
Author

@slashrsm slashrsm Oct 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it does not. I tried it in Chromium 29.0.1547.65 (Ubuntu 13.10) and Firefox 24.0.

.each(function(){
var dom = $.trim(this.nodeValue).replace(/^esi/,'').trim();
$(this).after(dom);
$(this).remove();
});
// Discover the <esi:include> tags.
jQuery.each(base_element.getElementsByTagName('esi:include'), function(i, val) {
// Some DOMs fail to recognise that the ESI include tag is self-
Expand Down