Skip to content

Conversation

@cillies-finatix
Copy link

No description provided.

@cillies-finatix cillies-finatix self-assigned this Nov 22, 2024
@cillies-finatix cillies-finatix force-pushed the 353-extract-auth-app branch 7 times, most recently from 6e5c52c to 6060f94 Compare November 29, 2024 09:50
@cillies-finatix cillies-finatix marked this pull request as ready for review November 29, 2024 09:53
@cillies-finatix
Copy link
Author

Ready for Review

  • ☑️ created a clean new auth app using the vue cli and copied all components and views to it
  • ☑️ bundlized all libraries so they provided a esm and cjs module
  • ☑️ bundlize libs/component using vue cli

How to review

Goal was to be able to extract and decouple the auth app from the monorepo and its libraries.

  • cp -r hackathon-demo/apps/auth auth-standalone
  • cd auth-standalone
  • npm install --legacy-peer-deps -> We are now using the latest Typescript version, that seems to be incompatible with ts-jest, somehow.
  • npm run build -> works
  • npm run serve-> works

ℹ️ Note that I've added a npm-dependency using a github url of "hackathon-demo". This should later become a real npm-registry release for all our libraries.

@cillies-finatix
Copy link
Author

cillies-finatix commented Dec 5, 2024

Tests are working again :) Updated to latest Jest. So now it really can be reviewed and merged then.

Now even all the shared libraries can run as a standalone project. They now include their corresponding package-lock and dependencies.

I just need a "Go" to copy these parts to the datev-research repository.

@cillies-finatix
Copy link
Author

Ich hab das Thema Custom Style für den Authorization App Header hier mit eingebaut.

@cillies-finatix
Copy link
Author

Tests are now working in Standalone app :) I'll merge this PR now

@cillies-finatix cillies-finatix merged commit cf949fa into market Dec 9, 2024
@cillies-finatix cillies-finatix deleted the 353-extract-auth-app branch December 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants