Basic Blocks refactoring#112
Open
akhilguruprasad22 wants to merge 2 commits intomandiant:enhance/52from
Open
Conversation
mike-hunhoff
requested changes
Apr 30, 2024
Collaborator
mike-hunhoff
left a comment
mike-hunhoff
left a comment
There was a problem hiding this comment.
Thanks @akhilguruprasad22 , I've left comments for your review. I'm a little confused as to how the changes you've made here relate to the discussions that we've been having in #52. Please provide additional context.
Comment on lines
+239
to
+241
| else: | ||
| assert bb_curr is not None | ||
| bb_curr.instructions.append(insn) |
Collaborator
There was a problem hiding this comment.
Can you provide context for this change? What is it addressing?
Contributor
Author
There was a problem hiding this comment.
This change was made in accordance to: mandiant/capa#1326 (comment)
Comment on lines
+272
to
+274
| else: | ||
| bb.succs.append(bb_next) | ||
| bb_next.preds.append(bb) |
Collaborator
There was a problem hiding this comment.
Can you provide context for this change? What is it addressing?
Contributor
Author
There was a problem hiding this comment.
This change was made in accordance to:
mandiant/capa#1326 (comment)
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post review refactoring