Skip to content

Add missing type annotations to core CIL classes#172

Open
Kemalau wants to merge 1 commit intomandiant:mainfrom
Kemalau:kemal/type-annotations-core-models
Open

Add missing type annotations to core CIL classes#172
Kemalau wants to merge 1 commit intomandiant:mainfrom
Kemalau:kemal/type-annotations-core-models

Conversation

@Kemalau
Copy link

@Kemalau Kemalau commented Mar 18, 2026

This PR adds the remaining missing type annotations in the small core CIL helper classes touched by issue #8.

Changes:

  • annotate CilMethodBodyFlags.__str__, CilMethodBodyFlags.__repr__, and nested _to_print
  • annotate Instruction.__init__ and Instruction.mnemonic
  • annotate OpCode.__init__

Validation:

  • mypy dncil
  • pytest -q

Closes #8

@google-cla
Copy link

google-cla bot commented Mar 18, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add type annotations

2 participants