upgrade strxml to fix warnings related to tap included in build#31
Open
kriscarle wants to merge 4 commits intomapbox:masterfrom
Open
upgrade strxml to fix warnings related to tap included in build#31kriscarle wants to merge 4 commits intomapbox:masterfrom
kriscarle wants to merge 4 commits intomapbox:masterfrom
Conversation
|
Will there be any work done on this? |
|
+1 Now that |
Author
|
@kszafran @bobi7 It doesn't seem like Mapbox is still using or maintaining this code, so I went ahead and converted this PR to a fork, and published v0.5.0 here https://www.npmjs.com/package/@maphubs/tokml |
|
@kriscarle I actually switched to your fork yesterday. Thanks for publishing it to npm! |
gabrieldeal
added a commit
to gabrieldeal/route-wizard
that referenced
this pull request
Jan 27, 2020
by switching to a version of `tokml` that is being (somewhat?) maintained. mapbox/tokml#31 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was still using the original version of strxml that included tap in dependences. All the tests are passing again.
This is mainly to fix security warnings coming from old versions of uglify etc. that are pulled in by this repo https://snyk.io/test/npm/tokml/0.4.0