Add convenient method to clean all loaded (cached) instances#140
Open
Kjuly wants to merge 1 commit intomarcoarment:masterfrom
Open
Add convenient method to clean all loaded (cached) instances#140Kjuly wants to merge 1 commit intomarcoarment:masterfrom
Kjuly wants to merge 1 commit intomarcoarment:masterfrom
Conversation
Kjuly
force-pushed
the
pr+cleanAllLoadedInstances
branch
from
b8e1083 to
eb906b8
Compare
Contributor
Author
|
Note: Updated the PR based on latest commit after merging Unique2 br. |
Contributor
Author
|
Hi @marcoarment , plz take a review when u got time, and let me know if u've any concern about it, thx in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @marcoarment ,
Like issue mentioned in #106, when we cleaned several tables' records locally (execute sql statement directly) & try to pull data from server, these cached records will lead some problems.
e.g., we use
updatedAtto judge whether need to update local record w/ the one fetched from server. As cached record will always have a sameupdatedAtto the one fetched from server, as a result, when cleaned local data & pull again from server, no new record will be created locally after pulling, cause we think these record exists & values are latest. Especially for the case that fetch big records one by one.Though there's a way to load all cached instances w/
+allLoadedInstancesand remove one by one w/-removeFromCache, I think it's good to provide a convenient method to remove the whole cached array ing_instancesat once. :)