fix: SmokeStart wrong UniqueID2() #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport of 097b925
Regression introduced with this v5 commit 097b925 and noticed while backporting it into the v4, see the CI https://github.com/markus-wa/demoinfocs-golang/actions/runs/16401553730/job/46341730756?pr=599. We still group grenades by type to fix the UniqueID2() issue and store grenades in a slice like it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of 097b925 into v4 to fix #596.
I noticed a regression introduced in the v5 commit 097b925.
Weaponmay be nil inPlayerHurtevents instead of being a grenade, see the CI https://github.com/markus-wa/demoinfocs-golang/actions/runs/16401553730/job/46341730756?pr=599.To fix both issues, I still group grenades by type (same as v5 commit), and store grenades in a slice like before.