fix: possible nil players/weapons fields in some events #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix all warnings about nil values in game events such as Kill, PlayerHurt... in the cs-demo-analyzer project.
akiver
commented
Jul 21, 2025
Comment on lines
+473
to
+477
| if killer == nil && data["attacker_pawn"] != nil { | ||
| // CS2 only, fallback to pawn handle if the killer was not found by its user ID | ||
| killer = geh.parser.gameState.Participants().FindByPawnHandle(uint64(data["attacker_pawn"].GetValLong())) | ||
| } | ||
|
|
There was a problem hiding this comment.
this fixes a known incorrect kill/death count in a test https://github.com/akiver/cs-demo-analyzer/pull/24/files#diff-25dc70c821db25b975178adecd11c29fc460ea6f5e7bf29e8d0cd195d705f2caL505-R509
|
LGTM, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix all warnings about nil values in game events such as
Kill,PlayerHurt... in the cs-demo-analyzer project.