Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

refactor(button): Reduce build warnings by using sass modules as opposed to top-level-functions. #8252

Closed
wants to merge 1 commit into from
Closed

refactor(button): Reduce build warnings by using sass modules as opposed to top-level-functions. #8252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/mdc-button/_button-shared-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
@use '@material/theme/theme';
@use '@material/theme/theme-color';
@use '@material/typography/typography';
@use './button-ripple';
@use 'button-ripple';

$height: 36px !default;
$horizontal-padding: 8px !default;
Expand Down Expand Up @@ -526,6 +526,7 @@ $disabled-container-color: rgba(
$feat-structure: feature-targeting.create-target($query, structure);

@include feature-targeting.targets($feat-structure) {
// stylelint-disable-next-line shorthand-property-no-redundant-values --
// $padding should be a single value; enforce it by specifying all 4 sides in the output
padding: 0 $padding 0 $padding;
}
Expand Down Expand Up @@ -745,7 +746,7 @@ $disabled-container-color: rgba(
);

.mdc-button__focus-ring {
@if $radius-value != 0 and type-of($radius-value) == 'number' {
@if $radius-value != 0 and meta.type-of($radius-value) == 'number' {
@include focus-ring.focus-ring-radius(
$ring-radius: $radius-value,
$query: $query
Expand Down Expand Up @@ -779,7 +780,7 @@ $disabled-container-color: rgba(
);

.mdc-button__focus-ring {
@if $offset-value != 0 and type-of($offset-value) == 'number' {
@if $offset-value != 0 and meta.type-of($offset-value) == 'number' {
@include focus-ring.focus-ring-offset(
$offset: $offset-value,
$query: $query
Expand Down
Loading