Skip to content

Conversation

@lucas-labs
Copy link
Member

Description

Closes: #3040

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucas-labs,

Thanks a lot for the PR — I really appreciate the effort you've put into this! 🙌

I spent some time looking closely at the icon changes, and I wanted to share some honest thoughts. While I totally get the intention behind refreshing the icon, I’m not quite convinced that the proposed version is an improvement over the current one. To be fair, I also don’t think the existing icon is perfect, but the new one might be seen by some as a bit of a downgrade, mainly because it moves further away from the recognizable style of the original EditorConfig logo — just with slightly more noticeable glasses and a subtly altered shape.

For now, I’d suggest either keeping the current icon as-is or perhaps iterating further by keeping the overall shape and style closer to the original, while still exploring ways to enhance it.

Would love to hear your thoughts on this! Thanks again for your work on it 😊

@lucas-labs
Copy link
Member Author

Yeah, I actually agree.
The EditorConfig logo just isn’t very “iconeable”. It’s not geometric, which makes it hard to work with at small sizes, and trying to force it into a geometric shape ends up creating something totally different like this attempt.

This isn’t the first time I’ve tried to make an icon for it. Back when I did the perfect-pixel icons, I ended up just sticking with the original logo.
Might still be the best call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon Request]: .editorconfig

2 participants