Skip to content

Conversation

@bennajah
Copy link

@bennajah bennajah commented Aug 6, 2025

Description

add trpc folder icons

Contribution Guidelines

Signed-off-by: Bennajah <[email protected]>
@github-actions github-actions bot added the icons PR with new icons label Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Aug 7, 2025

Thanks for creating a PR. It's quite difficult to make out the shape of the motive in the small scale of the file explorer of VS Code. Would you mind to refine that icon a little bit? Maybe try to fill the small cubes, so that they are more visible.

Additionally try to align the icon with our 16x16 grid system:
https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#designing-pixel-perfect-icons

image

@bennajah
Copy link
Author

bennajah commented Aug 7, 2025

i have updated the icons to make it more visible

folder-trpc
folder-trpc-open

@PKief
Copy link
Member

PKief commented Aug 8, 2025

Hi thanks for the update. However I can still see that the edges look a little bit strange. Could you please check that?

image

@PKief PKief mentioned this pull request Aug 10, 2025
2 tasks
@bennajah
Copy link
Author

Hi thanks for the update. However I can still see that the edges look a little bit strange. Could you please check that?

image

now i think its better

folder-trpc-open
folder-trpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants