[WIP] Add auto_ncl to VaspJob#369
Draft
mkhorton wants to merge 2 commits intomaterialsproject:masterfrom
Draft
Conversation
Allows Custodian to more easily work with non-collinear VASP.
Comment on lines
+119
to
+120
| executable or with "gamma" replacing "std" in the name of | ||
| the VASP executable (typical setup in many systems). If so, run the |
Member
There was a problem hiding this comment.
@mkhorton: I think this is very smart to do, seeing as VASP ships it this way (and not with .gamma). I don't see the change made to the source code though, so if that's the case, just a head's up!
| to the last argument of the standard vasp_cmd. | ||
| ncl_vasp_cmd (str): Command for non-collinear vasp version when | ||
| auto_ncl is True. Should follow the list style of subprocess. | ||
| Defaults to none, which means "ncl" will replace "std" in |
Member
There was a problem hiding this comment.
VASP ships as vasp_ncl so that should probably be what is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows Custodian to more easily work with non-collinear VASP.
Opening in draft, still WIP, needs tests.