Use Numpy for all revisions#641
Merged
mathoudebine merged 8 commits intomathoudebine:mainfrom Feb 12, 2025
Merged
Conversation
5d4f60e to
fdb9b58
Compare
Contributor
Author
|
Rebased on top of main now that #622 is merged |
Owner
|
Thank you @hchargois much easier to read! |
Owner
|
@hchargois I successfully tested your PR against the 3 display revisions, everything works fine! |
matthewgjohnson
pushed a commit
to matthewgjohnson/turing-smart-screen-python
that referenced
this pull request
Feb 23, 2026
Use Numpy for all revisions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the use of numpy for serializing the image data of revisions B, C and D. Cf. #319
I've added tests to make sure the new serialization results in exactly the same calls to the serial interface as before. The tests can be run like this:
python -m unittestfrom the root directory.The tests can also be used as simple benchmarks (in that case the assertions are not checked) like this:
BENCHMARK=1 python -m unittestOn my machine, the benchmark results are as follows (before -> after)
This PR is based off of #622 so ideally that one should be merged before this one.