Skip to content

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Nov 25, 2025

MSC4108 designates 404 / M_NOT_FOUND to non-existing (and possibly expired) rendezvous sessions. This introduces dedicated NotFound errors so that consumers of the SDK can handle this case accordingly.

  • Public API changes documented in changelogs (optional)

@Johennes Johennes marked this pull request as ready for review November 25, 2025 15:45
@Johennes Johennes requested a review from a team as a code owner November 25, 2025 15:45
@Johennes Johennes requested review from andybalaam and removed request for a team November 25, 2025 15:45
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 25, 2025

CodSpeed Performance Report

Merging #5898 will not alter performance

Comparing Johennes:johannes/not-found (13b2273) with main (45a9d96)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 93.60000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.66%. Comparing base (ec44c74) to head (13b2273).
⚠️ Report is 35 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...atrix-sdk/src/authentication/oauth/qrcode/grant.rs 92.12% 7 Missing and 3 partials ⚠️
.../matrix-sdk/src/authentication/oauth/qrcode/mod.rs 81.25% 3 Missing ⚠️
.../src/authentication/oauth/qrcode/secure_channel.rs 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5898      +/-   ##
==========================================
+ Coverage   88.65%   88.66%   +0.01%     
==========================================
  Files         362      362              
  Lines      103146   103363     +217     
  Branches   103146   103363     +217     
==========================================
+ Hits        91440    91645     +205     
- Misses       7458     7471      +13     
+ Partials     4248     4247       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the extensive tests.

@poljar poljar merged commit fccafd8 into matrix-org:main Nov 26, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants