feat(sdk): Add Client::optimize_stores #5911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method should trigger any optimization/maintenance behaviours available to the stores, like `VACUUM` in SQLite
jmartinesp
force-pushed
the
misc/add-client-optimize-stores-method
branch
from
a40c0e6 to
44514c3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5911 +/- ##
==========================================
- Coverage 88.66% 88.57% -0.10%
==========================================
Files 362 362
Lines 104399 104498 +99
Branches 104399 104498 +99
==========================================
- Hits 92569 92556 -13
- Misses 7499 7609 +110
- Partials 4331 4333 +2 ☔ View full report in Codecov by Sentry. |
…raits Only SQLite based stores will implement it for now, calling the `SqliteAsyncConnExt::vacuum` method
…uccessfully This was a bit confusing, because I treated a lack of logs as success when in reality my code was calling an empty implementation
CodSpeed Performance ReportMerging #5911 will not alter performanceComparing Summary
|
jmartinesp
force-pushed
the
misc/add-client-optimize-stores-method
branch
from
44514c3 to
20f1921
Compare
… in production Also fix lint issue
jmartinesp
force-pushed
the
misc/add-client-optimize-stores-method
branch
2 times, most recently
from
a019a09 to
876bbf8
Compare
This method will retrieve the database sizes if available and expose it in the client. Note: the actual database size measuring is only implemented for the SQLite based stores
jmartinesp
force-pushed
the
misc/add-client-optimize-stores-method
branch
from
876bbf8 to
7a81959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods to perform cleanup/maintenance/optimization actions in the stores, so we can manually trigger them from the clients. This is a first attempt to understand if running these optimizations fixes an observed issue in the clients where the DB performance degrades severely as the cache grows.
Also added another set of methods to calculate the store sizes, when possible (
Client::get_store_sizes+*Store::get_size).cc @Hywan
Signed-off-by: