Minor code cleanup and modernization #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves the responsibility of reading from the file to the BufferHolder. This seems to make the responsibilities a bit clearer, although I also method on the buffers could work.
This introduces some breaking changes due to the accessor method naming pattern.
I realize this is contentious among some Java programmers, but given that most people modifying this code will be familiar with this pattern from other languages (Go, C#, etc.), this seems like an improvement.
|
This is easiest to review commit by commit. |
horgh
requested changes
Oct 10, 2025
| } | ||
|
|
||
| for (ByteBuffer buffer : buffers) { | ||
| channel.read(buffer); |
There was a problem hiding this comment.
Probably unnecessary, but would we want to have similar checks that we read the expected amount as in the non-test code?
| + this.ipVersion + ", nodeCount=" + this.nodeCount | ||
| + ", recordSize=" + this.recordSize + "]"; | ||
| long searchTreeSize() { | ||
| return nodeCount * nodeByteSize(); |
There was a problem hiding this comment.
This was calculated once before and just returned, whereas now we run this (and the above one) every time, right? Is that okay? I think there's a Network method in the same position.
There was a problem hiding this comment.
The Network method was an intentional compromise. The previous lazy loading had race conditions and it didn't seem that beneficial. This one would probably make sense to calculate only once though.
They were not public and are used in hot paths.
horgh
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a major release.