Skip to content

Conversation

@TheBrutalX
Copy link

@TheBrutalX TheBrutalX commented Nov 11, 2025

This pull request introduces support for allowing self-signed SSL certificates in the daemon's HTTP client configuration. The main changes add a new configuration option to enable or disable acceptance of self-signed certificates, propagate this setting through the configuration system, and update the HTTP client initialization logic accordingly.

Configuration changes:

  • Added a new allow_self_signed_certs option to both the CliArgs and AppConfig structs, with corresponding updates to their default implementations and configuration merging logic. [1] [2] [3] [4]
  • Added a get_allow_self_signed_certs method to the ConfigStore to retrieve the new configuration value.

HTTP client initialization:

  • Updated the DaemonRuntimeService::new method to use the allow_self_signed_certs configuration: if enabled, the HTTP client is built to accept invalid (self-signed) certificates.

@mayanayza
Copy link
Owner

Thanks for adding this! The DaemonDiscoveryService has it's own client property separate from the runtime service so you'll probably want to implement it there too. Look for:

pub struct DaemonDiscoveryService {
pub config_store: Arc,
pub client: reqwest::Client,
pub utils: PlatformDaemonUtils,
pub current_session: Arc<RwLock<Option>>,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants