Fix bash 3.2 compatibility: case conversion syntax#27
Merged
mbailey merged 1 commit intombailey:masterfrom Jan 27, 2026
Merged
Conversation
Replace ${var^^} and ${var,,} with helper functions that use tr.
These bash 4+ case conversion operators fail on macOS default bash 3.2.
Changes:
- Add _mt_uppercase() and _mt_lowercase() helper functions
- Replace all ${var^^} with $(_mt_uppercase "$var")
- Replace all ${var,,} with $(_mt_lowercase "$var")
Files changed:
- lib/functions.sh: 5 replacements + helper functions
- lib/prompt.sh: 8 replacements
Tested on macOS Tahoe (arm64) with bash 3.2.57.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${var^^}and${var,,}with helper functions usingtrProblem
After merging #26, the install still fails on bash 3.2:
The
${var^^}(uppercase) and${var,,}(lowercase) operators require bash 4+.Solution
Add helper functions in
lib/functions.sh:Then replace all usages:
${var^^}→$(_mt_uppercase "$var")${var,,}→$(_mt_lowercase "$var")Changes
lib/functions.shlib/prompt.shTesting
Tested on fresh macOS Tahoe VM (arm64) with bash 3.2.57.
Note
This is the second of potentially several PRs needed for full bash 3.2 compatibility. Remaining issues may include:
mapfileinlib/service.sh(7 usages)declare -Aassociative arrays (if any critical paths use them)🤖 Generated with Claude Code