#1786 sync virtual console button colour to RGB button custom feedback #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Can you please fix the build and also edit the PR comment to follow this template? .github/PULL_REQUEST_TEMPLATE/feature_or_fix.md Cheers |
add missing part to import header file - qmath.h in inputselectionwidget.cpp
vcbutton has same default colours
Binary-Vanguard-12138
force-pushed
the
feature/virtual_console_button_colour
branch
from
3111995 to
117cfa4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
- Add checkbox to syncronize button colour with input source colour
- Set default feedback values to 0
- Set button colour to similar colour with Red for Off, Green for On and Yellow for Monitoring if it is set not to syncronize
Related Issues: Related to #1786