Refactor Code

[saleh-alhaddad]

This PR refactors to improve code readability, maintainability, and robustness.

[BertramScharpf]

I had almost the same ideas. But instead of waiting several years for a merge, I opened my own project. In case you're interested, it's called BertramScharpf/ruby-popt.

[saleh-alhaddad]

@BertramScharpf let's mention them again as they are busy in most of the time.

cc: @olleolleolle @mdp @shaiguitar

[mdp]

Sorry, unless there's a security issue or a bug I'm pretty hesitant to push updates to this library, it's a library that doesn't change much (and TOTP has largely been deprecated by security conscious orgs), and due to its security role I'm extra cautious.

That being said, it's been a while since it's been updated and I needed to fix a Github workflow and test issue (was failing on >3.3). I don't want to force a rebase on your PR branch, so I'll let you do it, but if you rebase this PR to 'main' it should run the test workflow and verify that everything passes (I ran them on my own and it looks good). Then I'll merge it into main, although I likely won't push a release unless there some additional changes that come in later and require it.

Thanks