Support reqwest_middleware and OpenTelemetry#19
Merged
masongup-mdsol merged 8 commits intomasterfrom Dec 10, 2024
Merged
Conversation
ykitamura-mdsol
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the client to implement the interfaces for reqwest_middleware, allowing for simpler and cleaner code on usage, and for easy integration with other outgoing middlewares. This is also used, along with supporting OpenTelemetry, to sign outgoing requests to MAuth, allowing for full OpenTelemetry tracing support when used in web services.
Also moves the public key cache into a global static to avoid the awkwardness of keeping it in each copy of the MAuth struct.