Skip to content

disable cuda tests in local_sgd_integ_test #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

disable cuda tests in local_sgd_integ_test #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions torchft/local_sgd_integ_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,11 @@ def state_dict() -> Dict[str, Dict[str, object]]: # pyre-ignore[53]


class LocalSGDIntegTest(TestCase):
# TODO: race condition due to using NCCL in threads causes manager allreduce to sometimes not be correct
# Because of that the test is disabled for cuda
@parameterized.expand(
[
(True,),
# (True,),
(False,),
]
)
Expand Down Expand Up @@ -259,7 +261,7 @@ def test_local_sgd_recovery(self, use_cuda: bool) -> None:

@parameterized.expand(
[
(True,),
# (True,),
(False,),
]
)
Expand Down Expand Up @@ -319,7 +321,7 @@ def test_diloco_healthy(self, use_cuda: bool) -> None:

@parameterized.expand(
[
(True,),
# (True,),
(False,),
]
)
Expand Down