reset flight recorder trace #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84260745. |
meta-cla
bot
added
the
CLA Signed
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 16, 2025
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
force-pushed
the
export-D84260745
branch
2 times, most recently
from
1d99280 to
d048341
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 16, 2025
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 16, 2025
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
force-pushed
the
export-D84260745
branch
from
d048341 to
19ec38e
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 16, 2025
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
force-pushed
the
export-D84260745
branch
from
19ec38e to
06ae4f8
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
force-pushed
the
export-D84260745
branch
from
06ae4f8 to
2132ea5
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
force-pushed
the
export-D84260745
branch
from
2132ea5 to
eaf4f9e
Compare
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Differential Revision: D84880993
Summary: - call FR api to reset the trace after every quorum - we reset so that after every quorum, we start a fresh FR trace since the pg's could have changed and we already dumped FR trace from previous errors - change the env var that's used to determine the file after every quorum Differential Revision: D84260745
tushar00jain
force-pushed
the
export-D84260745
branch
from
eaf4f9e to
229e4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D84260745