lighthouse, manager: support multiple quorum rooms #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
d4l3k/multiple_quorum
branch
from
1982445 to
8f3ec1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the lighthouse and manager to support multiple "rooms" for quorum.
This is intended to be support having a "join" quorum and a "shrink-only" quorum that is needed for LocalSGD (#39)
This may also have the side-effect of being able to support multiple jobs with a single Lighthouse server but that's not being actively targeted currently. We still have shared state in Lighthouse (i.e. heartbeats are global and require globally unique replica_ids).
Test plan: